alamb commented on code in PR #8928:
URL: https://github.com/apache/arrow-datafusion/pull/8928#discussion_r1462286087
##########
datafusion/expr/src/expr.rs:
##########
@@ -1266,6 +1266,54 @@ impl Expr {
Ok(Transformed::Yes(expr))
})
}
+
+ /// Returns true if some of this `exprs` subexpressions may not be
evaluated
+ /// and thus any side effects (like divide by zero) may not be encountered
+ pub fn short_circuits(&self) -> bool {
+ match self {
+ Expr::ScalarFunction(ScalarFunction { func_def, .. }) => {
+ matches!(func_def, ScalarFunctionDefinition::BuiltIn(fun) if
*fun == BuiltinScalarFunction::Coalesce)
+ }
+ Expr::BinaryExpr(BinaryExpr { op, .. }) => {
+ matches!(op, Operator::And | Operator::Or)
+ }
+ Expr::Case { .. } => true,
+ // Use explicit pattern match instead of a default
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
