jorisvandenbossche commented on code in PR #39557:
URL: https://github.com/apache/arrow/pull/39557#discussion_r1463015865
##########
python/pyproject.toml:
##########
@@ -18,7 +18,12 @@
[build-system]
requires = [
"cython >= 0.29.31",
- "oldest-supported-numpy>=0.14",
+ # Starting with NumPy 1.25, NumPy is (by default) as far back compatible
+ # as oldest-support-numpy was (customizable with a NPY_TARGET_VERSION
Review Comment:
As far as I understand, oldest-supported-numpy pins to a _newer_ numpy
version for some platforms / architectures (like arm) because the older version
that is theoretically supported has bugs. But so that means that if we always
use the latest available version for a platform, that should be fine?
Of course, there might be a new bug occurring in the latest version, and at
that point, defaulting to "the latest available version" might temporarily give
issues, compared to pinning to a slightly older but "known to be OK" version
(for example, if we know 1.25 is fine, we could pin to that in case the newest
1.26.x would introduce a bug).
But that's a problem for all packages building against numpy, and so it
would be good if numpy would have guidelines around this. And my understanding
is that it is now recommended to built against the latest numpy version
(although
https://numpy.org/devdocs/dev/depending_on_numpy.html#build-time-dependency is
not explicit about that, it just mentions that starting from 1.25, you can use
that version to built packages that are also compatible with older numpy)
cc @seberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
