seberg commented on code in PR #39557:
URL: https://github.com/apache/arrow/pull/39557#discussion_r1463032761
##########
python/pyproject.toml:
##########
@@ -18,7 +18,12 @@
[build-system]
requires = [
"cython >= 0.29.31",
- "oldest-supported-numpy>=0.14",
+ # Starting with NumPy 1.25, NumPy is (by default) as far back compatible
+ # as oldest-support-numpy was (customizable with a NPY_TARGET_VERSION
Review Comment:
That sounds all exactly right.
I suppose the docs linked could recommend to compile against the latest
available version (unless there be bugs). This is required for major releases,
i.e. NumPy 2 (you cannot build releases against it yet since there is no `rc`,
though. I still need to opaquify the descriptor struct a bit, which you may
notice).
To continue supporting building against pre 2.0 releases, you may have to
vendor `(numpy/_core/include/)numpy/npy_2_compat.h`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
