comphead commented on code in PR #8945:
URL: https://github.com/apache/arrow-datafusion/pull/8945#discussion_r1463847822
##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1552,10 +1549,10 @@ pub fn create_window_expr_with_name(
e: &Expr,
name: impl Into<String>,
logical_input_schema: &DFSchema,
+ physical_input_schema: &Schema,
Review Comment:
Thanks @mustafasrepo
I'm still thinking if we need to have a physical schema? This is misleading
a bit, we always need to keep in mind why the schemas are not the same, what is
their difference, etc.
Basically we have a check earlier in the planner that asserts equality for
the schema from batch and from the planner.
https://github.com/search?q=repo%3Aapache%2Farrow-datafusion%20mismatch%20between&type=code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
