mustafasrepo commented on code in PR #8945:
URL: https://github.com/apache/arrow-datafusion/pull/8945#discussion_r1464365812


##########
datafusion/core/src/physical_planner.rs:
##########
@@ -1552,10 +1549,10 @@ pub fn create_window_expr_with_name(
     e: &Expr,
     name: impl Into<String>,
     logical_input_schema: &DFSchema,
+    physical_input_schema: &Schema,

Review Comment:
   Thanks @comphead, It seems that we really don't need physical_input_schema. 
Removed it, thanks for the suggestion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to