alamb opened a new pull request, #8983: URL: https://github.com/apache/arrow-datafusion/pull/8983
## Which issue does this PR close? Part of https://github.com/apache/arrow-datafusion/issues/8724 Follow on to https://github.com/apache/arrow-datafusion/pull/8780 ## Rationale for this change The new canonicalize API added in https://github.com/apache/arrow-datafusion/pull/8780: 1. Has to be explictly called (so existing users of the ExprSimplifer will not get its benefits by default) 2. Has a diferent API than the existing [`ExprSimplifer::with_guarantees`](https://docs.rs/datafusion/latest/datafusion/optimizer/simplify_expressions/struct.ExprSimplifier.html#method.with_guarantees) ## What changes are included in this PR? 1. Add `Simplifier::with_canonicalize` and update code to use it 2. Add documentation and example ## Are these changes tested? Yes, with new doc example as well as existing code ## Are there any user-facing changes? Better api + documentation. cc @Jefffrey -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
