alamb commented on code in PR #8983:
URL: https://github.com/apache/arrow-datafusion/pull/8983#discussion_r1465262005


##########
datafusion/optimizer/src/simplify_expressions/simplify_exprs.rs:
##########
@@ -98,6 +96,7 @@ impl SimplifyExpressions {
             // The left and right expressions in a Join on clause are not 
commutative,
             // since the order of the columns must match the order of the 
children.
             LogicalPlan::Join(_) => {
+                let simplifier = 
ExprSimplifier::new(info).with_canonicalize(false);

Review Comment:
   😍  I love it. I did it in e7095cdb8 and it looks much nicer now. Thank you 
@yyy1000 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to