alamb commented on code in PR #8897:
URL: https://github.com/apache/arrow-datafusion/pull/8897#discussion_r1467021651
##########
datafusion/sqllogictest/Cargo.toml:
##########
@@ -61,6 +61,7 @@ postgres = ["bytes", "chrono", "tokio-postgres",
"postgres-types", "postgres-pro
[dev-dependencies]
env_logger = { workspace = true }
num_cpus = { workspace = true }
+tokio = { version = "1.0", features = ["rt-multi-thread"] }
Review Comment:
why is this needed?
##########
datafusion/sqllogictest/test_files/repartition_scan.slt:
##########
@@ -253,7 +253,16 @@ query TT
EXPLAIN SELECT * FROM arrow_table
----
logical_plan TableScan: arrow_table projection=[f0, f1, f2]
-physical_plan ArrowExec: file_groups={1 group:
[[WORKSPACE_ROOT/datafusion/core/tests/data/example.arrow]]}, projection=[f0,
f1, f2]
+physical_plan ArrowExec: file_groups={4 groups:
[[WORKSPACE_ROOT/datafusion/core/tests/data/example.arrow:0..461],
[WORKSPACE_ROOT/datafusion/core/tests/data/example.arrow:461..922],
[WORKSPACE_ROOT/datafusion/core/tests/data/example.arrow:922..1383],
[WORKSPACE_ROOT/datafusion/core/tests/data/example.arrow:1383..1842]]},
projection=[f0, f1, f2]
Review Comment:
👍 looks good to me -- though I I wonder will this actually read in parallel
(or do these ranges all end up in the same reader)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
