yyy1000 commented on PR #8985: URL: https://github.com/apache/arrow-datafusion/pull/8985#issuecomment-1911508870
> Thanks @yyy1000 👍 , could you check the output schema in your test like [main...JasonLi-cn:arrow-datafusion:feature/refactor_udf](https://github.com/apache/arrow-datafusion/compare/main...JasonLi-cn:arrow-datafusion:feature/refactor_udf) @Weijun-H Thanks for your review! Aha, it seems that my current implementation still use `return_type` to get the schema. Maybe here changing `return_type` to `return_type_from_exprs` would be a good idea. But a problem is here the schema has type `S: ExprSchema` while `return_type_from_exprs` can't accept a generic type parameter `S` because it's in a trait. 🤔 What do you think? https://github.com/apache/arrow-datafusion/blob/4d02cc0114908d4f805b2323f20751b1f6d9c2f4/datafusion/expr/src/expr_schema.rs#L106-L108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
