alamb commented on code in PR #8985:
URL: https://github.com/apache/arrow-datafusion/pull/8985#discussion_r1469493769
##########
datafusion/expr/src/udf.rs:
##########
@@ -249,6 +261,22 @@ pub trait ScalarUDFImpl: Debug + Send + Sync {
/// the arguments
fn return_type(&self, arg_types: &[DataType]) -> Result<DataType>;
+ /// What [`DataType`] will be returned by this function, given the types of
+ /// the expr arguments
+ fn return_type_from_exprs(
+ &self,
+ arg_exprs: &[Expr],
+ schema: &DFSchema,
+ ) -> Result<DataType> {
Review Comment:
> Maybe here changing return_type to return_type_from_exprs would be a good
idea. But a problem
is here the schema has type S: ExprSchema while return_type_from_exprs can't
accept a generic type parameter S because it's in a trait. 🤔 What do you think?
Maybe you can use a trait object like `&dyn ExprSchema` 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
