alamb commented on code in PR #8991:
URL: https://github.com/apache/arrow-datafusion/pull/8991#discussion_r1468161433
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -1529,15 +1521,8 @@ mod tests {
) -> Result<(Vec<String>, Vec<RecordBatch>)> {
let partition_count = 4;
- let (left_expr, right_expr) = on
- .iter()
- .map(|(l, r)| {
- (
- Arc::new(l.clone()) as Arc<dyn PhysicalExpr>,
- Arc::new(r.clone()) as Arc<dyn PhysicalExpr>,
- )
- })
- .unzip();
+ let (left_expr, right_expr) =
+ on.iter().map(|(l, r)| (l.clone(), r.clone())).unzip();
Review Comment:
In many ways this change makes the code cleaner as it doesn't have to
special case Column so much
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -278,7 +277,7 @@ pub struct HashJoinExec {
/// right (probe) side which are filtered by the hash table
pub right: Arc<dyn ExecutionPlan>,
/// Set of equijoin columns from the relations: `(left_col, right_col)`
- pub on: Vec<(Column, Column)>,
+ pub on: Vec<(PhysicalExprRef, PhysicalExprRef)>,
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
