mustafasrepo commented on code in PR #8991:
URL: https://github.com/apache/arrow-datafusion/pull/8991#discussion_r1469171957
##########
datafusion/core/src/physical_optimizer/enforce_distribution.rs:
##########
@@ -1886,8 +1887,8 @@ pub(crate) mod tests {
// Join on (a == b1)
let join_on = vec![(
- Column::new_with_schema("a", &schema()).unwrap(),
- Column::new_with_schema("b1", &right.schema()).unwrap(),
+ Arc::new(Column::new_with_schema("a", &schema()).unwrap()) as _,
Review Comment:
I think we can use `col` function (which is in the
file`datafusion/physical_expr/src/expressions/column.rs`) here
as `col("a", &schema()).unwrap()` instead of
`Arc::new(Column::new_with_schema("a", &schema()).unwrap()) as _`. However,
there are lots of changes like this. And it is purely stylistic. This change is
not important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
