jp0317 commented on code in PR #39818:
URL: https://github.com/apache/arrow/pull/39818#discussion_r1468739331
##########
cpp/src/parquet/column_reader_benchmark.cc:
##########
@@ -219,5 +251,19 @@ BENCHMARK(RecordReaderReadRecords)
->Args({2, 1000, true})
->Args({2, 1000, false});
+BENCHMARK(RecordReaderReadAndSkipRecords)
+ ->ArgNames({"Repetition", "BatchSize"})
Review Comment:
done, thanks for catching this! I feel here probably magnitude matters more
than power-of-two (or not power-of-two might be better) for testing purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
