pitrou commented on code in PR #39818:
URL: https://github.com/apache/arrow/pull/39818#discussion_r1472547295
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -70,6 +70,8 @@ namespace {
// The minimum number of repetition/definition levels to decode at a time, for
// better vectorized performance when doing many smaller record reads
constexpr int64_t kMinLevelBatchSize = 1024;
+// The max buffer size of validility bitmap for skipping buffered levels.
+constexpr int64_t kMaxSkipLevelBufferSize = 128;
Review Comment:
Reallocating could be more costly than simply deallocating, since you need
to copy the data when reallocating. I'm not saying this is relevant here, just
pointing out that reallocation is mostly better _if you need to keep the actual
data, not just the memory area_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
