jayzhan211 commented on code in PR #8902:
URL: https://github.com/apache/arrow-datafusion/pull/8902#discussion_r1469113119
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -577,19 +578,14 @@ fn coerce_arguments_for_fun(
let mut expressions: Vec<Expr> = expressions.to_vec();
- // Cast Fixedsizelist to List for array functions
- if *fun == BuiltinScalarFunction::MakeArray {
+ // coerce the fixed size list to list for all array fucntions
+ if fun.name().contains("array") {
Review Comment:
There are two problems that I think we should stick to the previous checking.
1. name() takes the first aliases of the function, so if there we forgot the
have first aliases starts with array, it fails.
2. We just need to care about `make_array` only, then other functions should
get non-fixedsizelsit as input.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
