jayzhan211 commented on code in PR #8902:
URL: https://github.com/apache/arrow-datafusion/pull/8902#discussion_r1470525879
##########
datafusion/optimizer/src/analyzer/type_coercion.rs:
##########
@@ -577,19 +578,14 @@ fn coerce_arguments_for_fun(
let mut expressions: Vec<Expr> = expressions.to_vec();
- // Cast Fixedsizelist to List for array functions
- if *fun == BuiltinScalarFunction::MakeArray {
+ // coerce the fixed size list to list for all array fucntions
+ if fun.name().contains("array") {
Review Comment:
Ok, I know the reason, it seems we still need to handle fixedsizelist for
other array functions because we can pass Fixedsizelist directly to them with
`arrow_cast`.
In this case, I agree we should handle them in
`coerce_arguments_for_signature`. And, `coerce_arguments_for_fun` can be
removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
