viirya commented on code in PR #9031:
URL: https://github.com/apache/arrow-datafusion/pull/9031#discussion_r1470043292
##########
datafusion/proto/tests/cases/roundtrip_physical_plan.rs:
##########
@@ -578,8 +578,9 @@ fn roundtrip_builtin_scalar_function() -> Result<()> {
"acos",
fun_expr,
vec![col("a", &schema)?],
- DataType::Int64,
+ DataType::Float64,
Review Comment:
The existing test is not correct at all. `acos` built-in scalar function's
return type should be `Float64`.
Previously the roundtrip test passes because `from_proto` simply takes serde
return type and uses it as parameter to `ScalarFunctionExpr`.
But in this PR, `from_proto` calls `create_physical_expr` which gets return
type directly from `BuiltinScalarFunction`. So with the PR, this test issue is
found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
