viirya commented on code in PR #9031:
URL: https://github.com/apache/arrow-datafusion/pull/9031#discussion_r1470302950
##########
datafusion/physical-expr/src/scalar_function.rs:
##########
@@ -149,6 +153,11 @@ impl PhysicalExpr for ScalarFunctionExpr {
{
vec![ColumnarValue::create_null_array(batch.num_rows())]
}
+ // If the function supports zero argument, we pass in a null array
indicating the batch size.
Review Comment:
Good idea. Changed to `self.args.is_empty()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
