DDtKey commented on code in PR #9096: URL: https://github.com/apache/arrow-datafusion/pull/9096#discussion_r1474334899
########## datafusion/sqllogictest/test_files/join.slt: ########## @@ -614,8 +614,8 @@ query TI SELECT t1.a, t1.b FROM t1 JOIN t2 ON t1.a = t2.a ORDER BY t1.a, t2.b; ---- Alice 50 -Alice 50 Alice 100 +Alice 50 Review Comment: Btw, why do we have test-cases with incorrect results, knowing this? It seems it would be useful to have a set of tests that can fail, but do not block CI, etc (something like TDD, we know it fails and we can make it work) It will be much easier to find test-cases that don't work right now. The tests won't even have to be changed, except perhaps excluded from the "expectedly fail" category. сс @alamb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
