viirya commented on code in PR #9096: URL: https://github.com/apache/arrow-datafusion/pull/9096#discussion_r1474691737
########## datafusion/sqllogictest/test_files/join.slt: ########## @@ -614,8 +614,8 @@ query TI SELECT t1.a, t1.b FROM t1 JOIN t2 ON t1.a = t2.a ORDER BY t1.a, t2.b; ---- Alice 50 -Alice 50 Alice 100 +Alice 50 Review Comment: Nice catch. Yea, this existing test now matches correct behaviors after this PR. Actually it is same issue (order by with same column name in joined sides). Updated the test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
