viirya commented on code in PR #9096:
URL: https://github.com/apache/arrow-datafusion/pull/9096#discussion_r1475105750


##########
datafusion/core/src/physical_optimizer/projection_pushdown.rs:
##########
@@ -916,7 +916,9 @@ fn update_expr(
                     .find_map(|(index, (projected_expr, alias))| {
                         
projected_expr.as_any().downcast_ref::<Column>().and_then(
                             |projected_column| {
-                                
column.name().eq(projected_column.name()).then(|| {
+                                (column.name().eq(projected_column.name())

Review Comment:
   I think for `new_columns_for_join_on` and `new_indices_for_join_filter`, you 
won't hit a similar issue like this. The reason is 
https://github.com/apache/arrow-datafusion/pull/9096#discussion_r1474725804.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to