bkietz commented on a change in pull request #9294:
URL: https://github.com/apache/arrow/pull/9294#discussion_r566365009
##########
File path: cpp/src/arrow/testing/gtest_util.h
##########
@@ -79,15 +79,18 @@
EXPECT_THAT(_st.ToString(), (matcher));
\
} while (false)
-#define ASSERT_OK(expr) \
- do { \
- auto _res = (expr); \
- ::arrow::Status _st = ::arrow::internal::GenericToStatus(_res); \
- if (!_st.ok()) { \
- FAIL() << "'" ARROW_STRINGIFY(expr) "' failed with " << _st.ToString(); \
- } \
+#define EXPECT_RAISES_WITH_CODE_AND_MESSAGE_THAT(code, matcher, expr) \
+ do { \
+ auto _res = (expr); \
+ ::arrow::Status _st = ::arrow::internal::GenericToStatus(_res); \
+ EXPECT_EQ(_st.CodeAsString(), Status::CodeAsString(code)); \
+ EXPECT_THAT(_st.ToString(), (matcher)); \
} while (false)
+#define ASSERT_OK(expr)
\
+ for (::arrow::Status _st = ::arrow::internal::GenericToStatus((expr));
!_st.ok();) \
+ FAIL() << "'" ARROW_STRINGIFY(expr) "' failed with " << _st.ToString()
Review comment:
It allows extra context to be streamed into the assertion, as with
library GTEST macros:
```c++
ASSERT_OK(some_function(some_var)) << "extra context: " << some_var;
```
##########
File path: cpp/src/arrow/dataset/expression_internal.h
##########
@@ -109,6 +105,40 @@ struct Comparison {
return less.scalar_as<BooleanScalar>().value ? LESS : GREATER;
}
+ static const Expression& StripOrderPreservingCasts(const Expression& expr) {
Review comment:
will do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
