bkietz commented on a change in pull request #9294:
URL: https://github.com/apache/arrow/pull/9294#discussion_r566368622
##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_internal.cc
##########
@@ -149,17 +149,13 @@ void CastNumberToNumberUnsafe(Type::type in_type,
Type::type out_type, const Dat
// ----------------------------------------------------------------------
void UnpackDictionary(KernelContext* ctx, const ExecBatch& batch, Datum* out) {
- if (out->is_scalar()) {
- KERNEL_ASSIGN_OR_RAISE(*out, ctx,
-
batch[0].scalar_as<DictionaryScalar>().GetEncodedValue());
- return;
- }
+ DCHECK(out->is_array());
DictionaryArray dict_arr(batch[0].array());
const CastOptions& options = checked_cast<const
CastState&>(*ctx->state()).options;
const auto& dict_type = *dict_arr.dictionary()->type();
- if (!dict_type.Equals(options.to_type)) {
+ if (!dict_type.Equals(options.to_type) && !CanCast(dict_type,
*options.to_type)) {
Review comment:
In general, CanCast needs more overhaul. I'll add a follow up JIRA and
mention the `guaranteed_safe=false` kwarg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
