universalmind303 commented on code in PR #8985:
URL: https://github.com/apache/arrow-datafusion/pull/8985#discussion_r1483826996
##########
datafusion/expr/src/udf.rs:
##########
@@ -249,6 +261,22 @@ pub trait ScalarUDFImpl: Debug + Send + Sync {
/// the arguments
fn return_type(&self, arg_types: &[DataType]) -> Result<DataType>;
+ /// What [`DataType`] will be returned by this function, given the types of
+ /// the expr arguments
+ fn return_type_from_exprs(
+ &self,
+ arg_exprs: &[Expr],
+ schema: &DFSchema,
+ ) -> Result<DataType> {
Review Comment:
I'm not super familiar with `ExprSchema`, but a quick look seems like it's
only applicable to a single Expr, and therefore a single column instead of the
entire schema?
I think retaining the entire schema would be more flexible. For example,
[this](https://github.com/GlareDB/glaredb/issues/2113) is only possible if you
have the entire schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
