yyy1000 commented on code in PR #8985:
URL: https://github.com/apache/arrow-datafusion/pull/8985#discussion_r1483827834


##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -136,7 +136,7 @@ impl ExprSchemable for Expr {
                         fun.return_type(&arg_data_types)
                     }
                     ScalarFunctionDefinition::UDF(fun) => {
-                        Ok(fun.return_type(&arg_data_types)?)
+                        fun.return_type_from_exprs(args, schema)

Review Comment:
   @alamb @brayanjuls . It's here, when it will get the return type of 
`ScalarUDF`, and for UDF, it should be changed to this.
   However, this can't work because `schema` needs to be `Sized`. Here is the 
error from my complier.
   <img width="952" alt="Screenshot 2024-02-08 at 9 32 38 PM" 
src="https://github.com/apache/arrow-datafusion/assets/69566909/9cfdff48-0940-45d2-bddc-f0f60a40dfd0";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to