indigophox commented on issue #39791: URL: https://github.com/apache/arrow/issues/39791#issuecomment-1936748014
@lidavidm while you were on the right track with suggesting moving this out to the gRPC transport handler shims, on closer inspection it's also going to break the exact thing that MiddlewareScenario tests for (response headers working in case of a failed call) *unless* I/we monkey with or replace usage of the `SERVICE_RETURN_NOT_OK` macro at e.g. https://github.com/apache/arrow/blob/990e4756183cfa9e69236aeb0af7aeb5f70f1978/cpp/src/arrow/flight/transport/grpc/grpc_server.cc#L522-L523 Preference as to how we proceed here? I'm thinking either duplicate or special-case the macro (not so keen on the latter), or handle the non-OK return at exactly the spot above via catch-and-"rethrow" i.e. conditionally (or not) invoke the service response macro around the non-OK Status/Result after handling the headers. Any objections to the latter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
