indigophox commented on issue #39791: URL: https://github.com/apache/arrow/issues/39791#issuecomment-1942313422
Just realizing that this gets messy insofar as skipping middleware response header injection in (at least in the simpler implementation—this can be worked around with a lot of noisy code) all cases except for those where the Flight handler is actually called. In other words, if we fail on `CheckAuth()`/`MakeCallContext()` or any of the subsequent `CHECK_ARG_NOT_NULL`/etc macros we (by default) don't go get response headers from the middleware instance. Maybe not a concern (I don't like the super-noisy check-return-every-time-manually-sort-of-like-we-do-around-the-Flight-handler-call alternative), but what do you think here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
