niyue commented on code in PR #40031:
URL: https://github.com/apache/arrow/pull/40031#discussion_r1485493907
##########
cpp/src/gandiva/CMakeLists.txt:
##########
@@ -36,6 +36,7 @@ provide_cmake_module(GandivaAddBitcode "Gandiva")
# Set the path where the bitcode file generated, see precompiled/CMakeLists.txt
set(GANDIVA_PRECOMPILED_BC_PATH "${CMAKE_CURRENT_BINARY_DIR}/irhelpers.bc")
+set(GANDIVA_PRECOMPILED_MANDATORY_BC_PATH
"${CMAKE_CURRENT_BINARY_DIR}/mandatory_ir.bc")
set(GANDIVA_PRECOMPILED_CC_PATH
"${CMAKE_CURRENT_BINARY_DIR}/precompiled_bitcode.cc")
Review Comment:
There are two bitcode files now, the original `irhelpers.bc` is optionally
used, and the `mandatory_ir.bc` is mandatory and always linked to the LLVM
module constructed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
