niyue commented on code in PR #40031:
URL: https://github.com/apache/arrow/pull/40031#discussion_r1485494494
##########
cpp/src/gandiva/engine.cc:
##########
@@ -211,6 +213,7 @@ Status UseJITLinkIfEnabled(llvm::orc::LLJITBuilder&
jit_builder) {
Result<std::unique_ptr<llvm::orc::LLJIT>> BuildJIT(
llvm::orc::JITTargetMachineBuilder jtmb,
+ std::unique_ptr<llvm::TargetMachine> target_machine,
Review Comment:
This is a minor change, after profiling, I found constructing
`TargetMachine` takes some time, and here I tries to re-use the `TargetMachine`
instance created previously.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
