alamb commented on code in PR #5385:
URL: https://github.com/apache/arrow-rs/pull/5385#discussion_r1485675147
##########
arrow-json/src/writer.rs:
##########
@@ -1192,7 +1192,7 @@ mod tests {
assert_json_eq(
&buf,
-
r#"{"duration_sec":"PT120S","duration_msec":"PT0.120S","duration_usec":"PT0.000120S","duration_nsec":"PT0.000000120S","name":"a"}
+
r#"{"duration_sec":"PT120S","duration_msec":"PT0.12S","duration_usec":"PT0.00012S","duration_nsec":"PT0.00000012S","name":"a"}
Review Comment:
this looks better
##########
arrow-cast/src/display.rs:
##########
@@ -1013,9 +1013,9 @@ mod tests {
assert_eq!(pretty[2], "0 days 0 hours 0 mins 0.000001000 secs");
assert_eq!(iso[3], "-PT0.000001S");
assert_eq!(pretty[3], "0 days 0 hours 0 mins -0.000001000 secs");
- assert_eq!(iso[4], "P45DT50554.123456789S");
+ assert_eq!(iso[4], "PT3938554.123456789S");
Review Comment:
why did these values change? They look closer to the pretty version with the
former formatting (like 45 days)
Is this something we need to change in pretty print?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
