tustvold commented on code in PR #5385:
URL: https://github.com/apache/arrow-rs/pull/5385#discussion_r1485675293


##########
arrow-cast/src/display.rs:
##########
@@ -1013,9 +1013,9 @@ mod tests {
         assert_eq!(pretty[2], "0 days 0 hours 0 mins 0.000001000 secs");
         assert_eq!(iso[3], "-PT0.000001S");
         assert_eq!(pretty[3], "0 days 0 hours 0 mins -0.000001000 secs");
-        assert_eq!(iso[4], "P45DT50554.123456789S");
+        assert_eq!(iso[4], "PT3938554.123456789S");

Review Comment:
   As per the PR description - https://github.com/chronotope/chrono/pull/1328 
changed the formatting to be more "correct". As the pretty version is focused 
on human readability, not precision, I am not sure it needs to be updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to