Tom-Newton opened a new pull request, #40119:
URL: https://github.com/apache/arrow/pull/40119
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's
Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing
Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue for this pull request on GitHub?
https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the
[Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.)
of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
In the case of PARQUET issues on JIRA the title also supports:
PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
Prevent confusion if a user attempts to read or write a directory.
### What changes are included in this PR?
- Make `ObjectAppendStream::Flush` a noop if `ObjectAppendStream::Init` has
not run successfully. This avoids an unhandled error when the destructor calls
flush.
- Check blob properties for directory marker metadata when initialising
`ObjectInputFile` or `ObjectAppendStream`.
- When initialising `ObjectAppendStream` call `GetFileInfo` if it is a flat
namespace account.
### Are these changes tested?
Add new tests `DisallowReadingOrWritingDirectoryMarkers` and
`DisallowCreatingFileAndDirectoryWithTheSameName` to cover the new fail fast
behaviour.
Also updated `WriteMetadata` to ensure that my changes to Flush didn't break
setting metadata without calling `Write` on the stream.
### Are there any user-facing changes?
Yes. Invalid read and write operations will now fail fast and gracefully.
Previously could get into a confusing state where there were files and
directories at the same path and there were some un-graceful failures.
<!--
If there are any breaking changes to public APIs, please uncomment the line
below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix
either (a) a security vulnerability, (b) a bug that caused incorrect or invalid
data to be produced, or (c) a bug that causes a crash (even when the API
contract is upheld). We use this to highlight fixes to issues that may affect
users without their knowledge. For this reason, fixing bugs that cause errors
don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
