felipecrv commented on code in PR #40119:
URL: https://github.com/apache/arrow/pull/40119#discussion_r1495056656
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -698,11 +721,15 @@ class ObjectAppendStream final : public io::OutputStream {
ObjectAppendStream(std::shared_ptr<Blobs::BlockBlobClient> block_blob_client,
const io::IOContext& io_context, const AzureLocation&
location,
const std::shared_ptr<const KeyValueMetadata>& metadata,
- const AzureOptions& options, int64_t size = kNoSize)
+ const AzureOptions& options, const bool truncate,
+ std::function<Status()>
ensure_not_flat_namespace_directory,
Review Comment:
I thought you had to retain the funtions as a member of the file handle. If
you only need it on `Init` you can pass `*this` as an `Init` function parameter
avoiding unnecessary copying and bloating the destructor of every file handle
unnecessarily. You will still need to be-`friend` the classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
