pitrou commented on code in PR #40094:
URL: https://github.com/apache/arrow/pull/40094#discussion_r1494362112
##########
cpp/src/arrow/util/byte_stream_split_test.cc:
##########
@@ -147,20 +133,58 @@ class TestByteStreamSplitSpecialized : public
::testing::Test {
static std::vector<T> MakeRandomInput(int64_t num_values) {
std::vector<T> input(num_values);
random_bytes(kWidth * num_values, seed_++,
reinterpret_cast<uint8_t*>(input.data()));
- // Avoid NaNs to ease comparison
- for (auto& value : input) {
- if (std::isnan(value)) {
- value = nan_replacement_++;
- }
- }
return input;
}
+ template <bool kSimdImplemented = (kWidth == 4 || kWidth == 8)>
+ static std::vector<DecodeFunc> MakeDecodeFuncs() {
+ std::vector<DecodeFunc> funcs;
+ funcs.push_back({"scalar", &ByteStreamSplitDecodeScalarDynamic});
+ funcs.push_back({"scalar", &ByteStreamSplitDecodeScalar<kWidth>});
+#if defined(ARROW_HAVE_SIMD_SPLIT)
+ if constexpr (kSimdImplemented) {
+ funcs.push_back({"simd", &ByteStreamSplitDecodeSimd<kWidth>});
+#if defined(ARROW_HAVE_SSE4_2)
+ funcs.push_back({"sse2", &ByteStreamSplitDecodeSse2<kWidth>});
+#endif
+#if defined(ARROW_HAVE_AVX2)
+ funcs.push_back({"avx2", &ByteStreamSplitDecodeAvx2<kWidth>});
+#endif
+#if defined(ARROW_HAVE_AVX512)
+ funcs.push_back({"avx512", &ByteStreamSplitDecodeAvx512<kWidth>});
+#endif
+ }
+#endif // defined(ARROW_HAVE_SIMD_SPLIT)
+ return funcs;
+ }
+
+ template <bool kSimdImplemented = (kWidth == 4 || kWidth == 8)>
+ static std::vector<EncodeFunc> MakeEncodeFuncs() {
+ std::vector<EncodeFunc> funcs;
+ funcs.push_back({"reference", &ReferenceByteStreamSplitEncode});
+ funcs.push_back({"reference", &ByteStreamSplitEncodeScalarDynamic});
+ funcs.push_back({"scalar", &ByteStreamSplitEncodeScalar<kWidth>});
+#if defined(ARROW_HAVE_SIMD_SPLIT)
+ if constexpr (kSimdImplemented) {
+ funcs.push_back({"simd", &ByteStreamSplitEncodeSimd<kWidth>});
+#if defined(ARROW_HAVE_SSE4_2)
+ funcs.push_back({"sse2", &ByteStreamSplitEncodeSse2<kWidth>});
+#endif
+#if defined(ARROW_HAVE_AVX2)
+ funcs.push_back({"avx2", &ByteStreamSplitEncodeAvx2<kWidth>});
+#endif
+#if defined(ARROW_HAVE_AVX512)
+ funcs.push_back({"avx512", &ByteStreamSplitEncodeAvx512<kWidth>});
+#endif
+ }
+#endif // defined(ARROW_HAVE_SIMD_SPLIT)
+ return funcs;
+ }
+
std::vector<EncodeFunc> encode_funcs_;
std::vector<DecodeFunc> decode_funcs_;
static inline uint32_t seed_ = 42;
- static inline T nan_replacement_ = 0;
Review Comment:
The test has been changed to use integer types as the backing value types
(int32, int64) to avoid such issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
