pitrou commented on code in PR #40094:
URL: https://github.com/apache/arrow/pull/40094#discussion_r1494363091
##########
cpp/src/parquet/encoding.cc:
##########
@@ -801,98 +804,154 @@ void DictEncoderImpl<ByteArrayType>::PutDictionary(const
::arrow::Array& values)
// ----------------------------------------------------------------------
// ByteStreamSplitEncoder<T> implementations
+// Common base class for all types
+
template <typename DType>
-class ByteStreamSplitEncoder : public EncoderImpl, virtual public
TypedEncoder<DType> {
+class ByteStreamSplitEncoderBase : public EncoderImpl,
+ virtual public TypedEncoder<DType> {
public:
using T = typename DType::c_type;
using TypedEncoder<DType>::Put;
- explicit ByteStreamSplitEncoder(
- const ColumnDescriptor* descr,
- ::arrow::MemoryPool* pool = ::arrow::default_memory_pool());
+ ByteStreamSplitEncoderBase(const ColumnDescriptor* descr, int byte_width,
+ ::arrow::MemoryPool* pool =
::arrow::default_memory_pool())
Review Comment:
Not necessarily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
