jayzhan211 commented on code in PR #5408:
URL: https://github.com/apache/arrow-rs/pull/5408#discussion_r1495998589
##########
arrow-ord/src/cmp.rs:
##########
@@ -166,6 +168,122 @@ pub fn not_distinct(lhs: &dyn Datum, rhs: &dyn Datum) ->
Result<BooleanArray, Ar
compare_op(Op::NotDistinct, lhs, rhs)
}
+fn process_nested(
+ l: &dyn Array,
+ r: &dyn Array,
+ op: Op,
+ l_t: &DataType,
+ r_t: &DataType,
+ len: usize,
+) -> Result<Option<BooleanArray>, ArrowError> {
+ use arrow_schema::DataType::*;
+ if let (List(_), List(_)) = (l_t, r_t) {
+ // Process nested data types
+ match op {
Review Comment:
I'm unsure about using l.values and offsets for the comparison. Instead, I
find looping through the index with `.value(i)` much clearer and
straightforward for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
