tustvold commented on code in PR #5408:
URL: https://github.com/apache/arrow-rs/pull/5408#discussion_r1501313910
##########
arrow-ord/src/cmp.rs:
##########
@@ -702,4 +784,216 @@ mod tests {
neq(&col.slice(0, col.len() - 1), &col.slice(1, col.len() -
1)).unwrap();
}
+
Review Comment:
It would be good to see some tests of
* Scalar arguments
* Nulls masking non-empty slices
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
