pitrou commented on code in PR #40176: URL: https://github.com/apache/arrow/pull/40176#discussion_r1497730916
########## python/pyarrow/tests/test_io.py: ########## @@ -1137,7 +1142,14 @@ def test_memory_zero_length(tmpdir): def test_memory_map_large_seeks(): - check_large_seeks(pa.memory_map) + if sys.maxsize >= 2**32: + expected_error = None Review Comment: In this case, `expected_error` would swallow the error and `with f` would error out because `f` would be undefined :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
