kou commented on code in PR #40176:
URL: https://github.com/apache/arrow/pull/40176#discussion_r1498312186
##########
cpp/src/arrow/io/file.cc:
##########
@@ -560,17 +561,22 @@ class MemoryMappedFile::MemoryMap
RETURN_NOT_OK(::arrow::internal::FileTruncate(file_->fd(),
initial_size));
}
- size_t mmap_length = static_cast<size_t>(initial_size);
- if (length > initial_size) {
- return Status::Invalid("mapping length is beyond file size");
- }
- if (length >= 0 && length < initial_size) {
+ int64_t mmap_length = initial_size;
+ if (length >= 0) {
// memory mapping a file region
- mmap_length = static_cast<size_t>(length);
+ if (length > initial_size) {
+ return Status::Invalid("mapping length is beyond file size");
+ }
+ mmap_length = length;
+ }
+ if (static_cast<int64_t>(static_cast<size_t>(mmap_length)) != mmap_length)
{
+ return Status::CapacityError("Requested memory map length ", mmap_length,
+ " does not fit in a C size_t "
+ "(are you using a 32-bit build of Arrow?");
Review Comment:
")" is missing in error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
