Jefffrey commented on code in PR #5417:
URL: https://github.com/apache/arrow-rs/pull/5417#discussion_r1498199517
##########
arrow-buffer/src/util/bit_util.rs:
##########
@@ -117,6 +117,8 @@ mod tests {
assert_eq!(64, round_upto_multiple_of_64(64));
assert_eq!(128, round_upto_multiple_of_64(65));
assert_eq!(192, round_upto_multiple_of_64(129));
+ // TODO: investigate why this is failing
+ // assert_eq!(usize::MAX, round_upto_multiple_of_64(usize::MAX));
Review Comment:
On the other hand, without the saturating add it would've just overflowed so
would get an ever lower number (in release mode at least)
I think the bit manipulation involved doesn't handle it well when input is
maxed out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
