tustvold commented on code in PR #5417:
URL: https://github.com/apache/arrow-rs/pull/5417#discussion_r1498344086
##########
arrow-buffer/src/util/bit_util.rs:
##########
@@ -117,6 +117,8 @@ mod tests {
assert_eq!(64, round_upto_multiple_of_64(64));
assert_eq!(128, round_upto_multiple_of_64(65));
assert_eq!(192, round_upto_multiple_of_64(129));
+ // TODO: investigate why this is failing
+ // assert_eq!(usize::MAX, round_upto_multiple_of_64(usize::MAX));
Review Comment:
Perhaps we use checked add and return the maximum multiple of two in such a
case? Or check the value is sufficiently small at the start?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
