yyy1000 commented on code in PR #9313:
URL: https://github.com/apache/arrow-datafusion/pull/9313#discussion_r1498624486
##########
datafusion/substrait/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -304,10 +304,11 @@ async fn not_between_integers() -> Result<()> {
.await
}
-#[tokio::test]
-async fn simple_scalar_function_abs() -> Result<()> {
- roundtrip("SELECT ABS(a) FROM data").await
-}
+// TODO: disable this test until the support for UserDefinedScalarFunction
+// #[tokio::test]
+// async fn simple_scalar_function_abs() -> Result<()> {
+// roundtrip("SELECT ABS(a) FROM data").await
+// }
Review Comment:
I disabled this test case because now it seems impossible for substrait to
get a ScalarFunction from name. See:
https://github.com/apache/arrow-datafusion/blob/91f3eb2e5430d23e2b551e66732bec1a3a575971/datafusion/substrait/src/logical_plan/consumer.rs#L116-L130
and
https://github.com/apache/arrow-datafusion/blob/91f3eb2e5430d23e2b551e66732bec1a3a575971/datafusion/substrait/src/logical_plan/consumer.rs#L77-L82
I can try to implement this function in this PR or as a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
