jayzhan211 commented on code in PR #9313:
URL: https://github.com/apache/arrow-datafusion/pull/9313#discussion_r1501923503
##########
datafusion/functions/src/macros.rs:
##########
@@ -160,3 +160,43 @@ macro_rules! downcast_arg {
})?
}};
}
+
+macro_rules! make_abs_function {
Review Comment:
These are macros for `abs`, I think they should be moved to math.rs. Also,
you need to delete those macros in the old file `math_expressions.rs`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
