Divyansh200102 commented on code in PR #40186:
URL: https://github.com/apache/arrow/pull/40186#discussion_r1499220227
##########
cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc:
##########
@@ -1782,7 +1782,9 @@ const FunctionDoc strptime_doc(
("For each string in `strings`, parse it as a timestamp.\n"
"The timestamp unit and the expected string pattern must be given\n"
"in StrptimeOptions. Null inputs emit null. If a non-null string\n"
- "fails parsing, an error is returned by default."),
+ "fails parsing, an error is returned by default.\n"
+ "\n"
+ "**Note:** The strptime kernel currently ignores the %Z specifier for any
string."),
Review Comment:
No, https://github.com/apache/arrow/pull/40186#issuecomment-1957878137 is
not the error I am talking I figured that one out I was talking about when i
used `archery lint --clang-format --fix` commad below files were getting
edited for no reason.
```diff
diff --git a/python/pyarrow/array.pxi b/python/pyarrow/array.pxi
index ad01d4557..e441278ae 100644
--- a/python/pyarrow/array.pxi
+++ b/python/pyarrow/array.pxi
@@ -1748,7 +1748,8 @@ cdef class Array(_PandasConvertible):
inner_array = pyarrow_unwrap_array(casted_array)
except ArrowInvalid as e:
raise ValueError(
- f"Could not cast {self.type} to requested type
{target_type}: {e}"
+ f"Could not cast {self.type} to requested type {
+ target_type}: {e}"
)
else:
inner_array = self.sp_array
diff --git a/python/pyarrow/table.pxi b/python/pyarrow/table.pxi
index ee3872aa3..18b7944d1 100644
--- a/python/pyarrow/table.pxi
+++ b/python/pyarrow/table.pxi
@@ -3081,7 +3081,8 @@ cdef class RecordBatch(_Tabular):
inner_batch = pyarrow_unwrap_batch(casted_batch)
except ArrowInvalid as e:
raise ValueError(
- f"Could not cast {self.schema} to requested schema
{target_schema}: {e}"
+ f"Could not cast {self.schema} to requested schema {
+ target_schema}: {e}"
)
else:
inner_batch = self.sp_batch
diff --git a/python/pyarrow/types.pxi b/python/pyarrow/types.pxi
index e9bf56c62..1f7773174 100644
--- a/python/pyarrow/types.pxi
+++ b/python/pyarrow/types.pxi
@@ -133,7 +133,8 @@ cdef void* _as_c_pointer(v, allow_null=False) except *:
else:
capsule_name_str = capsule_name.decode()
raise ValueError(
- f"Can't convert PyCapsule with name '{capsule_name_str}' to
pointer address"
+ f"Can't convert PyCapsule with name '{
+ capsule_name_str}' to pointer address"
)
else:
raise TypeError(f"Expected a pointer value, got {type(v)!r}")
```
if you require the logs for the commands to understand better I can provide
you with that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
