Divyansh200102 commented on PR #40186: URL: https://github.com/apache/arrow/pull/40186#issuecomment-1961385864
> Docs preview was build, here is the [Python doc](http://crossbow.voltrondata.com/pr_docs/40186/python/generated/pyarrow.compute.strptime.html) and the [c++ doc](http://crossbow.voltrondata.com/pr_docs/40186/cpp/compute.html#conversions). It seems the Python change came through ok, while you'd probably want to add the same language to the [c++ doc](https://github.com/apache/arrow/blob/main/docs/source/cpp/compute.rst#L1330). @rok does this change look good to you? ```diff diff --git a/docs/source/cpp/compute.rst b/docs/source/cpp/compute.rst index e7310d2c0..82a8d2a11 100644 --- a/docs/source/cpp/compute.rst +++ b/docs/source/cpp/compute.rst @@ -1327,7 +1327,7 @@ provided by a concrete function :func:`~arrow::compute::Cast`. +-----------------+------------+--------------------+------------------+--------------------------------+-------+ | strftime | Unary | Temporal | String | :struct:`StrftimeOptions` | \(1) | +-----------------+------------+--------------------+------------------+--------------------------------+-------+ -| strptime | Unary | String-like | Timestamp | :struct:`StrptimeOptions` | | +| strptime | Unary | String-like | Timestamp | :struct:`StrptimeOptions` | \(2) | +-----------------+------------+--------------------+------------------+--------------------------------+-------+ The conversions available with ``cast`` are listed below. In all cases, a @@ -1343,6 +1343,8 @@ null input value is converted into a null output value. .. _detailed formatting documentation: https://howardhinnant.github.io/date/date.html#to_stream_formatting +* \(2) The strptime kernel currently ignores the %Z specifier for any string. + **Truth value extraction** +-----------------------------+------------------------------------+--------------+ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
