codonnell commented on code in PR #9335:
URL: https://github.com/apache/arrow-datafusion/pull/9335#discussion_r1501681196
##########
datafusion-examples/Cargo.toml:
##########
@@ -54,6 +78,6 @@ serde = { version = "1.0.136", features = ["derive"] }
serde_json = { workspace = true }
tempfile = { workspace = true }
tokio = { workspace = true, features = ["rt-multi-thread", "parking_lot"] }
-tonic = "0.11"
Review Comment:
I tried to capture this in the issue:
> There is an API incompatibility between tonic 0.10 and 0.11. We have 0.10
as a transitive dependency of arrow-flight, and datafusion-examples pulls in
0.11 directly. As a result the flight examples won't compile.
If that's not clear, I'm happy to clarify further.
##########
datafusion-examples/Cargo.toml:
##########
@@ -54,6 +78,6 @@ serde = { version = "1.0.136", features = ["derive"] }
serde_json = { workspace = true }
tempfile = { workspace = true }
tokio = { workspace = true, features = ["rt-multi-thread", "parking_lot"] }
-tonic = "0.11"
Review Comment:
I tried to capture this in the issue:
> There is an API incompatibility between tonic 0.10 and 0.11. We have 0.10
as a transitive dependency of arrow-flight, and datafusion-examples pulls in
0.11 directly. As a result the flight examples won't compile.
If that's not clear, I'm happy to clarify further.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
