codonnell commented on PR #9335: URL: https://github.com/apache/arrow-datafusion/pull/9335#issuecomment-1962901397
> Do we run (or at least build) these examples as part of the CI? Since if so that should've prevented the bump in the first place: #9176 I wondered about that, too. The flight examples were excluded in [this refactor](https://github.com/apache/arrow-datafusion/pull/8060/files#diff-afe5c39a3bee2aaaf614226a287b288aea04d8b914b22ee2c5188ea7d9fb8e90R28), presumably because the server examples run indefinitely and the client example needs a server to connect to. We _could_ add a `cargo check` for each flight sql example to the CI script; I'm not sure why we wouldn't. With this PR, `cargo check` passes for all the examples. I'm happy to add that if you think it would be valuable. > arrow-flight will have tonic version `0.11` in it's next release as it was also bumped: [apache/arrow-rs#5380](https://github.com/apache/arrow-rs/pull/5380) > > So we can downgrade for now until arrow `51.0.0` is released My thoughts, exactly. :+1: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
