andrebsguedes commented on code in PR #5425:
URL: https://github.com/apache/arrow-rs/pull/5425#discussion_r1501796943
##########
object_store/src/azure/credential.rs:
##########
@@ -189,13 +190,13 @@ impl AzureSigner {
/// Authorize a [`Request`] with an [`AzureAuthorizer`]
#[derive(Debug)]
pub struct AzureAuthorizer<'a> {
- credential: &'a AzureCredential,
+ credential: Option<&'a AzureCredential>,
account: &'a str,
}
impl<'a> AzureAuthorizer<'a> {
/// Create a new [`AzureAuthorizer`]
- pub fn new(credential: &'a AzureCredential, account: &'a str) -> Self {
+ pub fn new(credential: Option<&'a AzureCredential>, account: &'a str) ->
Self {
Review Comment:
Sure, I didn't realize this was visible. I am assuming we still want to add
the date and version headers even when skipping signature, am I correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
