andrebsguedes commented on code in PR #5425:
URL: https://github.com/apache/arrow-rs/pull/5425#discussion_r1501798901
##########
object_store/src/azure/builder.rs:
##########
@@ -809,15 +830,20 @@ impl MicrosoftAzureBuilder {
// Allow overriding defaults. Values taken from
// from
https://docs.rs/azure_storage/0.2.0/src/azure_storage/core/clients/storage_account_client.rs.html#129-141
let url = url_from_env("AZURITE_BLOB_STORAGE_URL",
"http://127.0.0.1:10000";)?;
- let key = match self.access_key {
- Some(k) => AzureAccessKey::try_new(&k)?,
- None => AzureAccessKey::try_new(EMULATOR_ACCOUNT_KEY)?,
+ let credential = if let Some(k) = self.access_key {
Review Comment:
I added this as part of the disable_emulator_key change but decided to keep
it after the removal because if I write a test that uses the emulator and
expects failure due to a broken SAS token the request will actually succeed
with the current version, and I find this really surprising as it can make bugs
go unnoticed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
