advancedxy commented on code in PR #111:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/111#discussion_r1502092718
##########
core/src/execution/datafusion/shuffle_writer.rs:
##########
@@ -460,32 +460,32 @@ fn append_columns(
};
}
- macro_rules! append_string_dict {
- ($kt:ident) => {{
+ macro_rules! append_byte_dict {
+ ($kt:ident, $byte_type:ty, $array:ty) => {{
Review Comment:
how about `$array -> $array_type`?
##########
core/src/execution/datafusion/spark_hash.rs:
##########
@@ -292,6 +292,12 @@ pub fn create_hashes<'a>(
DataType::LargeUtf8 => {
hash_array!(LargeStringArray, col, hashes_buffer);
}
+ DataType::Binary => {
Review Comment:
Just to confirm, this is for equal/hash contract for Spark side's sort
operations?
I noticed some error when testing.
##########
core/src/execution/datafusion/shuffle_writer.rs:
##########
@@ -1098,47 +1113,47 @@ fn make_dict_builder(datatype: &DataType, capacity:
usize) -> Box<dyn ArrayBuild
if matches!(value_type.as_ref(), DataType::LargeUtf8) =>
{
match key_type.as_ref() {
- DataType::Int8 => string_dict_builder_inner_helper!(
- Int16Type,
+ DataType::Int8 => byte_dict_builder_inner_helper!(
+ Int8Type,
Review Comment:
This is a bug fixes? It looks like we may lack some unit test coverage in
the rust side.
Maybe we should add more unit tests in the rust side in the follow-up PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
